Comments on: EPiServer code walkthrough #1 – 404 handler http://www.frederikvig.com/2010/01/episerver-code-walkthrough-1-404-handler/?utm_source=rss&utm_medium=rss&utm_campaign=episerver-code-walkthrough-1-404-handler Sat, 31 Jul 2010 01:46:23 +0000 hourly 1 http://wordpress.org/?v=3.0.1 By: Steve http://www.frederikvig.com/2010/01/episerver-code-walkthrough-1-404-handler/comment-page-1/#comment-180 Steve Fri, 29 Jan 2010 18:47:57 +0000 http://www.frederikvig.com/?p=1038#comment-180 A really nice walk through. Probably lots of code out there that we can learn from (what to do and what not to!) I'm all for removing incomplete or bad comments and commented out code. I usually keep this though (hoping code survives the blog comment): public override void ValidatePageTemplate() { // Do not validate // base.ValidatePageTemplate (); } The "// base.ValidatePageTemplate ();" part in this case is an attempt to document what we want the base to NOT do (in order to achieve the effect we're after.) Preventing base classes to run code in overridden members is not very common, so worth commenting. However, the first line of comment is probably enough. A really nice walk through. Probably lots of code out there that we can learn from (what to do and what not to!) I’m all for removing incomplete or bad comments and commented out code. I usually keep this though (hoping code survives the blog comment):

public override void ValidatePageTemplate()
{
// Do not validate
// base.ValidatePageTemplate ();
}

The “// base.ValidatePageTemplate ();” part in this case is an attempt to document what we want the base to NOT do (in order to achieve the effect we’re after.) Preventing base classes to run code in overridden members is not very common, so worth commenting. However, the first line of comment is probably enough.

]]>