Comments on: Extending search field with suggestion box

By: Part 5: Creating the search page – Create an EPiServer site from scratch | Frederik Vig - ASP.NET developer

Tue, 15 Dec 2009 23:07:46 +0000

[...] also added suggestion functionality to the quick search field. See my post Extending search field with suggestion box, for more information. All the code is also available on [...]

By: Frederik Vig

Frederik Vig — Mon, 12 Oct 2009 21:14:36 +0000

@Stefan – Updated the Get method now.
@Magnus – Added a filter to remove all pages that the Everyone group doesn’t have access to.

By: Frederik Vig

Frederik Vig — Fri, 09 Oct 2009 10:36:10 +0000

Thanks for both your comments!
@Stefan – I think I understand what you mean. I’ll do a test and update the code accordingly.
@Magnus – You’re absolutely right! I’m going to update the code this weekend.

By: Magnus Aycox

Magnus Aycox — Fri, 09 Oct 2009 07:31:16 +0000

Nice post. But…
If you are to cache the resulting page names and you are filtering on the current users permissions you open up for faulty or worse, insecure, behaviour.
What if the user that visits the search page has got admin permissions thereby collecting all pages of the site including all the business secrets (which of course includes compromising secrets in the page name). When the average Joe user visits the site he gets served with all these juicy page names that is above his access level.
Even worse in case that you have used SearchDataSource because then it’s not merely the page names that are exposed.
These flaws corrected, this makes for a mean auto complete… (Of course even “meaner” if used with the access flaw ;o)

By: Stefan Forsberg

Stefan Forsberg — Tue, 06 Oct 2009 08:58:22 +0000

This is really offtopic and I realise you didn’t write the caching methods, but may I suggest you change the way it fetches the data from cache?

At the moment it’s something like this (pseudcode):
if(HttpContext.Current.Cache[key] == null) set default value, otherwise return HttpContext.Current.Cache[key] cast to T. The problem with that is that there’s a chance (however unlikely) for a race condition here if the item with key is removed from cache after you do the null check. You’ll then get a exception, which can be somewhat of a pain to localize.

I think it would be better to do something like this (this does requiere T to be ref type though):
var value = HttpContext.Current.Cache[key] as T. If value is null return the default otherwise return value.

Hope that made sense.

By: Twitted by krirav

Twitted by krirav — Tue, 29 Sep 2009 07:43:49 +0000

[...] This post was Twitted by krirav [...]

By: Twitted by ravnevand

Twitted by ravnevand — Tue, 29 Sep 2009 07:43:15 +0000

[...] This post was Twitted by ravnevand [...]

By: Webmaster Crap » Blog Archive » Extending search field with suggestion box | Frederik Vig - ASP …

Fri, 18 Sep 2009 01:17:35 +0000

[...] Read more from the original source: Extending search field with suggestion box | Frederik Vig – ASP … [...]

By: Extending search field with suggestion box Hello CMS - the best cms website

Extending search field with suggestion box Hello CMS - the best cms website — Thu, 17 Sep 2009 17:29:05 +0000

[...] the original post: Extending search field with suggestion box By admin | category: cms | tags: aol, cms, code, fusion-context, help-users, [...]